On Wed, Jan 07, 2015 at 10:28:34AM -0800, Tom Haynes wrote: > > > On Jan 7, 2015, at 6:56 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > On Tue, Jan 06, 2015 at 04:28:08PM -0800, Tom Haynes wrote: > >> From: Peng Tao <tao.peng@xxxxxxxxxxxxxxx> > >> > >> Also pull nfs4_pnfs_ds_addr and nfs4_pnfs_ds to generic pnfs. > >> > >> They can all be reused by flexfile layout as well. > > > > Should this really go into pnfs_dev.c? It's not as generic as > > the other code handling the device cache. Maybe there should be > > a pnfs_nfs.c or similar for this code as well as the code moved to > > pnfs_nfsio.c earlier? > > While the code moving to pdfs_nfsio.c appears to be earlier, that > actually occurred later in the development process. I.e., it was not > available when this patch occurred. > > Having said that, I’m open to pnfs_nfs.c as you suggested. The code > moved to pnfs_nfsio.c was not moved to pnfs_dev.c because I really > did not see it being generic enough as you said. > Okay, the v4 patchset will apply this change. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
