On 7/17/2014 06:06, J. Bruce Fields wrote: > On Mon, Jul 14, 2014 at 02:59:44AM -0700, Christoph Hellwig wrote: >> On Fri, Jul 11, 2014 at 04:11:29PM -0400, J. Bruce Fields wrote: >>>> On Mon, Jul 07, 2014 at 02:15:56PM -0400, J. Bruce Fields wrote: >>>>>> - p = xdr_reserve_space(xdr, 6); >>>>>> + p = xdr_reserve_space(xdr, 20); >>>> >>>> Can we please convert all these magic numbers to expressions adding up >>>> sizeofs or where that doesn't fit use #defines? >>> >>> So, this would be >>> >>> xdr_reserve_space(xdr, 5 * sizeof(be32)); >>> >>> ? I guess that'd be OK. >> >> Yes, that makes a lot more sense. > > Sounds reasonable to me. I'm not volunteering for now. I will try to converting those codes today. thanks, Kinglong Mee > >> I'm still hoping to make progress >> on my krpcgen one day.. > > OK, good luck.... > > --b. > . > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
