Re: [PATCH] nfsd: Fix bad reserving space for encoding rdattr_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 10, 2014 at 03:54:51AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 07, 2014 at 02:15:56PM -0400, J. Bruce Fields wrote:
> > > -	p = xdr_reserve_space(xdr, 6);
> > > +	p = xdr_reserve_space(xdr, 20);
> 
> Can we please convert all these magic numbers to expressions adding up
> sizeofs or where that doesn't fit use #defines?

So, this would be 

	xdr_reserve_space(xdr, 5 * sizeof(be32));

?  I guess that'd be OK.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux