> #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64 > - const unsigned long *ul = (const unsigned long *)a; > + const __be64 *be = (const __be64 *)a; > > - return (ul[0] | (ul[1] ^ cpu_to_be64(1))) == 0UL; > + return (be[0] | (be[1] ^ cpu_to_be64(1))) == cpu_to_be64(0UL); Do you need the swap for 0UL? I know sparse treats 0 as special, so why wouldn't it treat 0UL special? Or just remove the 0UL postfix, no need for it in a simple comparism. Otherwise looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
