On Tue, Jul 08, 2014 at 02:03:01PM -0400, Jeff Layton wrote: > We never use anything above bit #3, so an unsigned long for each is > wasteful. Shrink them to a char each, and add some WARN_ON_ONCE calls if > we try to set or clear bits that would go outside those sizes. > > Note too that because atomic bitops work on unsigned longs, we have to > abandon their use here. That shouldn't be a problem though since we > don't really care about the atomicity in this code anyway. Using them > was just a convenient way to flip bits. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
