On Tue, Jul 08, 2014 at 02:03:00PM -0400, Jeff Layton wrote: > ...and replace it with a simple swap call. While trying to understand this code I'm failing to grasp the point of the fi_access counters. Why can't we simply grab a reference to file everytime we increment fi_access, and simply drop it evertime we decrement it? Note that the comment explaining fi_access also seems wrong, as it suggest contributing 0-4 to the counts, but at best we increment each one by 1 in a single operation. Also as you touch this area big time: I think fi_fds should be renamed to fi_fils or similar as we point to file structures and not fds. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
