On Mon, 30 Jun 2014 03:40:14 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Jun 26, 2014 at 03:12:17PM -0400, Jeff Layton wrote:
> > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> >
> > Use filp_close instead of open coding. filp_close does a bit more than
> > just release the locks and put the filp. It also calls ->flush and
> > dnotify_flush, both of which should be done here anyway.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> and this can probably move before the locking changes..
>
We can't, actually. filp_close also does an fput, and that doesn't get
added until this patch:
nfsd: Add locking to the nfs4_file->fi_fds[] array
But I can (and will) move it just after that patch.
Thanks,
--
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
