Re: [PATCH v2 037/117] nfsd: clean up helper __release_lock_stateid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 26, 2014 at 03:12:17PM -0400, Jeff Layton wrote:
> From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> 
> Use filp_close instead of open coding. filp_close does a bit more than
> just release the locks and put the filp. It also calls ->flush and
> dnotify_flush, both of which should be done here anyway.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

and this can probably move before the locking changes..

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux