On Jun 7, 2014, at 10:39 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Jun 05, 2014 at 03:16:30PM -0400, Weston Andros Adamson wrote: >> The refcounting on nfs_pgio_header was related to there being (possibly) >> more than one nfs_pgio_data. Now that nfs_pgio_data has been merged into >> nfs_pgio_header, there is no reason to do this ref counting. Just call >> the completion callback on nfs_pgio_release/nfs_pgio_error. > > > I think nfs_generic_pgio_reset isn't an all that descriptive name, why > not keep nfs_pgio_data_destroy? That sounds reasonable - I renamed because struct nfs_pgio_data is gone, but the name still makes sense. -dros -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html