On Jun 7, 2014, at 10:34 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Jun 05, 2014 at 03:16:28PM -0400, Weston Andros Adamson wrote: >> struct nfs_pgio_data only exists as a member of nfs_pgio_header, but is >> passed around everywhere, because there used to be multiple _data structs >> per _header. Many of these functions then use the _data to find a pointer >> to the _header. This patch cleans this up by merging the nfs_pgio_data >> structure into nfs_pgio_header and passing nfs_pgio_header around instead. >> >> Signed-off-by: Weston Andros Adamson <dros@xxxxxxxxxxxxxxx> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But now that we only have a _header and no _data should we just > call this struct nfs_pgio? That sounds reasonable. I’ll give it a shot when I rename nfs_page. -dros-- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html