On May 19, 2014, at 12:11 PM, Anna Schumaker <schumaker.anna@xxxxxxxxx> wrote:
> On 05/19/2014 11:34 AM, Christoph Hellwig wrote:
>>> -static void pnfs_writehdr_free(struct nfs_pgio_header *hdr)
>>> +static void pnfs_pgio_header_free(struct nfs_pgio_header *hdr)
>>> {
>>> pnfs_put_lseg(hdr->lseg);
>>> nfs_pgio_header_free(hdr);
>>> }
>> I think it should also be mossible to simply call pnfs_put_lseg
>> from nfs_pgio_header_free. pnfs_put_lseg handles a NULL argument fine,
>> is stubbed out for the non-pnfs case, and the other callers should never
>> have it set.
Great point.
>
> Every function in this area is identical to each other :). I'm already working on a patch series that combines these functions (and more!). It also needs more testing before I can submit, but I can update against these patches first to see if this unlocks other cleanups.
>
> Anna
OK, so maybe I’ll just remove this patch from v2 and let you take care of it?
-dros--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
