On May 19, 2014, at 11:29 AM, Jim Rees <rees@xxxxxxxxx> wrote: > Weston Andros Adamson wrote: > > For consistency, remove argument names in function declarations > > This conflicts with the style guide: Well, then so do many (most?) function declarations in nfs-land. > > Chapter 6: Functions > > In function prototypes, include parameter names with their data types. > Although this is not required by the C language, it is preferred in Linux > because it is a simple way to add valuable information for the reader. I personally disagree that function names provide “valuable information”. “struct page *page” -> “oh, it’s a page!” ;) I can just drop this patch if people don’t like it... -dros-- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
