On 04/25/2014 08:12 AM, Christoph Hellwig wrote: > On Mon, Apr 21, 2014 at 12:24:23PM -0400, Anna Schumaker wrote: >>> Okay. I'll rework everything into the pageio_ops and see how it looks! Maybe I'll see what I can do about updating the pnfs patches while I'm at it. >> I remember my issue with adding to the nfs_pageio_ops now. The file, object and block layouts along with the generic pnfs code all have their own read and write pageio_ops. Changing all of these seemed more tedious than adding a new struct only in the read and write code. > > Indeed, there's more instances in the pnfs code. I was hoping your > pending pnfs patches were addressing that, and the general code > duplication between the pnfs and "classic" I/O code. Sorry, my pnfs patches only touch pnfs.c. I'm hoping to get help from people who know more about each layout driver once they can take a look at what I did here. My new plan is to put them on top of Dros' work. > > I guess it's best to put in your patches as-is for now, and maybe in the > future we can get rid of the pageio_ops once more code is shared with > the pnfs path. > Sure. I'll post a v2 later today that addresses rearranging variables in the combined structs. Anna -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
