Re: [PATCH 07/17] NFS: Create a common rw_header_alloc and rw_header_free function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 17, 2014 at 05:09:31PM -0400, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
> 
> I create a new struct nfs_rw_ops to decide the differences between reads
> and writes.  This struct will be set when initializing a new
> nfs_pgio_descriptor, and then passed on to the nfs_rw_header when a new
> header is allocated.

To me it seems like adding this new vector confuses things.  From a look
at your whole tree it seems like all methods added to it could as well
be added to nfs_pageio_ops.  In that case we'd still keep separate
instances of nfs_pageio_ops for reads and writes, but most methods would
be that same.  I'm also defintively curious what you have on your
sleeves for pnfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux