On 04/18/2014 09:57 AM, Christoph Hellwig wrote: >> +struct nfs_pgio_res { >> + struct nfs4_sequence_res seq_res; >> + struct nfs_fattr * fattr; >> + struct nfs_writeverf * verf; /* used by write */ >> + const struct nfs_server *server; /* used by write */ >> + __u32 count; >> + int eof; /* used by read */ > Same comment as for the previous patch applies here. Also maybe > this should use a union to overlay the read/write only fields? I thought about a union, but I didn't know if it was worth it for only one or two differing variables. I can put one in that would make more sense, though. Thanks! > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html