On 04/18/2014 09:56 AM, Christoph Hellwig wrote:
>> /*
>> + * Arguments shared by the read and write call.
>> + */
>> +struct nfs_pgio_args {
>> + struct nfs4_sequence_args seq_args;
>> + struct nfs_fh * fh;
>> + struct nfs_open_context *context;
>> + struct nfs_lock_context *lock_context;
>> + nfs4_stateid stateid;
>> + __u64 offset;
>> + __u32 count;
>> + enum nfs3_stable_how stable; /* used by write */
>> + unsigned int pgbase;
>> + struct page ** pages;
>> + const u32 * bitmask; /* used by write */
>> +};
> It might make sense to keep the arguments only used for writes together
> at the end of the structure.
Makes sense. I'll fix that up, thanks!
Anna
>
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
