On Thu, 5 Dec 2013 05:27:17 -0800 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Dec 05, 2013 at 06:00:50AM -0500, Jeff Layton wrote: > > This patchset converts the LRU list in the nfsd duplicate reply cache to > > use the new list_lru infrastrucure. Note that this is based on top of > > the patch that I sent to Bruce earlier this week that fixes the > > svc_cacherep direct reclaim bug. I'm sending this as an RFC since I'm > > not 100% convinced it's an improvement. > > > > The majorly unintuitive thing about list_lru that I've found is that > > you can't call call list_lru_del from list_lru_walk. So, you need > > different routines to free an object depending on how it's being freed. > > That's because list_lru_walk already does all the accounting. You can > simply do an list_del_init and then return LRU_MOVED and you're done. > Well no...we have to take it off the hlist too, kmem_cache_free the object and fix up the accounting for the stats. list_lru handles the accounting for the lru list itself, but not for the rest of the housekeeping we have to do. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
