On 11/14/2013 11:47 AM, Cedric Blancher wrote: > On 13 November 2013 20:30, Anna Schumaker <bjschuma@xxxxxxxxxx> wrote: >> These patches implement just the SEEK NFS v4.2 operation. WRITE_PLUS is >> still under discussion with the IETF after my last series of patches, so I >> am holding off on resubmitting until after spec discussion dies down. >> >> Questions? Comments? Thoughts? >> Anna > > 1. Doesn't SEEK_HOLE/SEEK_DATA already work in NFSv4? I always had the > impression this worked there... If we did, it was vfs-level seeking. HOLE and DATA support are new to NFS with v4.2. > > 2. Does http://svn.nrubsig.org/svn/people/gisburn/code/sparsefiles/lsholes.c > work with your changes (the name is unfortunate, but its useful to > list the holes in a file and even has a short test)? lsholes.c passes on NFS with these changes, although I think it needs a "-h" option to tell me how to use it without looking at the code :) > > 3. If you implement SEEK_HOLE/SEEK_DATA support you have to alter > fpathconf() support and implement the _PC_MIN_HOLE_SIZE properly. I don't think the NFS server exports a "minimum hole size" attribute, so I don't know how to find this without spec changes. Anna > > Ced > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
