On 13 November 2013 20:30, Anna Schumaker <bjschuma@xxxxxxxxxx> wrote: > These patches implement just the SEEK NFS v4.2 operation. WRITE_PLUS is > still under discussion with the IETF after my last series of patches, so I > am holding off on resubmitting until after spec discussion dies down. > > Questions? Comments? Thoughts? > Anna 1. Doesn't SEEK_HOLE/SEEK_DATA already work in NFSv4? I always had the impression this worked there... 2. Does http://svn.nrubsig.org/svn/people/gisburn/code/sparsefiles/lsholes.c work with your changes (the name is unfortunate, but its useful to list the holes in a file and even has a short test)? 3. If you implement SEEK_HOLE/SEEK_DATA support you have to alter fpathconf() support and implement the _PC_MIN_HOLE_SIZE properly. Ced -- Cedric Blancher <cedric.blancher@xxxxxxxxx> Institute Pasteur -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html