On Wed, 2013-11-13 at 12:13 +-1100, NeilBrown wrote: +AD4- On Wed, 13 Nov 2013 00:30:53 +-0000 +ACI-Myklebust, Trond+ACI- +AD4- +ADw-Trond.Myklebust+AEA-netapp.com+AD4- wrote: +AD4- +AD4- +AD4- On Wed, 2013-11-13 at 11:23 +-1100, NeilBrown wrote: +AD4- +AD4- +AD4- But back to my problem: Following Trond's suggestion I've come up with the +AD4- +AD4- +AD4- following patch. Does it look right? +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- The +ACI-fd +AD0- -1+ACI- is just to stop us trying to close a non-open fd in an error +AD4- +AD4- +AD4- path. +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- The change from testing -+AD4-servicename to -+AD4-prog stops us from repeating the +AD4- +AD4- +AD4- failed DNS lookup on every request, not that the failure isn't fatal. +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- The last stanza makes sure we always reply to an upcall, with EINVAL if +AD4- +AD4- +AD4- nothing else seems appropriate. +AD4- +AD4- +AD4- +AD4- Wouldn't EACCES be more appropriate as a default? +AD4- +AD4- +AD4- +AD4- Maybe. And that is what you suggested before and I mis-remembered - sorry. +AD4- +AD4- However EACCES is +ACI-Permission denied+ACI- which doesn't quite seem right to me. +AD4- It isn't really +ACI-you aren't allowed to do that+ACI-, but +ACI-your question doesn't +AD4- make sense+ACI-. +AD4- +AD4- However I'm not fussed. If you prefer EACCES, then I'll make it EACCES. If you look at gss+AF8-pipe+AF8-downcall(), then you'll note that it treats EINVAL as a temporary error, and converts it to EAGAIN. That again causes call+AF8-refreshresult to retry the upcall 2 more times before failing with EACCES anyway... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
