On Wed, 2013-11-13 at 11:23 +-1100, NeilBrown wrote: +AD4- But back to my problem: Following Trond's suggestion I've come up with the +AD4- following patch. Does it look right? +AD4- +AD4- The +ACI-fd +AD0- -1+ACI- is just to stop us trying to close a non-open fd in an error +AD4- path. +AD4- +AD4- The change from testing -+AD4-servicename to -+AD4-prog stops us from repeating the +AD4- failed DNS lookup on every request, not that the failure isn't fatal. +AD4- +AD4- The last stanza makes sure we always reply to an upcall, with EINVAL if +AD4- nothing else seems appropriate. Wouldn't EACCES be more appropriate as a default? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
