Re: [PATCH] SUNRPC: Fix a data corruption issue when retransmitting RPC calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Myklebust, Trond [Trond.Myklebust@xxxxxxxxxx] wrote:
> On Mon, 2013-11-11 at 17:15 -0600, Malahal Naineni wrote:
> > Trond Myklebust [Trond.Myklebust@xxxxxxxxxx] wrote:
> > > @@ -700,13 +707,20 @@ static int xs_tcp_send_request(struct rpc_task *task)
> > >  	xs_pktdump("packet data:",
> > >  				req->rq_svec->iov_base,
> > >  				req->rq_svec->iov_len);
> > > +	/* Don't use zero copy if this is a resend. If the RPC call
> > > +	 * completes while the socket holds a reference to the pages,
> > > +	 * then we may end up resending corrupted data.
> > > +	 */
> > > +	if (task->tk_flags & RPC_TASK_SENT)
> > 
> > How about RPC_WAS_SENT() ?
> 
> <shrug>that evaluates to the same</shrug>

Yes, but what is the point of having a macro then?

Regards, Malahal.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux