Re: [PATCH] SUNRPC: Fix a data corruption issue when retransmitting RPC calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-11-11 at 17:15 -0600, Malahal Naineni wrote:
+AD4- Trond Myklebust +AFs-Trond.Myklebust+AEA-netapp.com+AF0- wrote:
+AD4- +AD4- +AEAAQA- -700,13 +-707,20 +AEAAQA- static int xs+AF8-tcp+AF8-send+AF8-request(struct rpc+AF8-task +ACo-task)
+AD4- +AD4-  	xs+AF8-pktdump(+ACI-packet data:+ACI-,
+AD4- +AD4-  				req-+AD4-rq+AF8-svec-+AD4-iov+AF8-base,
+AD4- +AD4-  				req-+AD4-rq+AF8-svec-+AD4-iov+AF8-len)+ADs-
+AD4- +AD4- +-	/+ACo- Don't use zero copy if this is a resend. If the RPC call
+AD4- +AD4- +-	 +ACo- completes while the socket holds a reference to the pages,
+AD4- +AD4- +-	 +ACo- then we may end up resending corrupted data.
+AD4- +AD4- +-	 +ACo-/
+AD4- +AD4- +-	if (task-+AD4-tk+AF8-flags +ACY- RPC+AF8-TASK+AF8-SENT)
+AD4- 
+AD4- How about RPC+AF8-WAS+AF8-SENT() ?

+ADw-shrug+AD4-that evaluates to the same+ADw-/shrug+AD4-

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust+AEA-netapp.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux