Re: [PATCH] nfs: fix pnfs Kconfig defaults

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-11-11 at 13:01 -0800, Christoph Hellwig wrote:
+AD4- On Mon, Nov 11, 2013 at 08:30:48PM +-0000, Myklebust, Trond wrote:
+AD4- +AD4- +AD4- diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
+AD4- +AD4- +AD4- index b5e80b0..f731180 100644
+AD4- +AD4- +AD4- --- a/fs/nfs/Kconfig
+AD4- +AD4- +AD4- +-+-+- b/fs/nfs/Kconfig
+AD4- +AD4- +AD4- +AEAAQA- -116,17 +-116,17 +AEAAQA- config NFS+AF8-V4+AF8-2
+AD4- +AD4- +AD4- config PNFS+AF8-FILE+AF8-LAYOUT
+AD4- +AD4- +AD4- 	tristate
+AD4- +AD4- +AD4- 	depends on NFS+AF8-V4+AF8-1
+AD4- +AD4- +AD4- -	default m
+AD4- +AD4- +AD4- +-	default NFS+AF8-FS
+AD4- +AD4- 
+AD4- +AD4- Shouldn?t that really be
+AD4- +AD4- 	default NFS+AF8-V4
+AD4- +AD4- in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.
+AD4- 
+AD4- Probably should.  For some reason I had NFS+AF8-V4+AF8-1 in mind as a bool.

NFS+AF8-V4+AF8-1 is indeed a bool, but it just defines whether or not we compile
v4.1 behaviour into the 'nfsv4 module' (which is controlled by the
tristate NFS+AF8-V4).

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust+AEA-netapp.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux