Re: [PATCH] nfs: fix pnfs Kconfig defaults

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 2, 2013, at 6:22, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> Defaulting to m seem to prevent building the pnfs layout modules into the
> kernel.  Default to the value of CONFIG_NFS_FS make sure they are
> built in for a built-in NFS and modular for a modular NFS.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> fs/nfs/Kconfig |    6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index b5e80b0..f731180 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -116,17 +116,17 @@ config NFS_V4_2
> config PNFS_FILE_LAYOUT
> 	tristate
> 	depends on NFS_V4_1
> -	default m
> +	default NFS_FS

Shouldn’t that really be
	default NFS_V4
in order to get the dependency right? The current Kconfig does allow you to have nfs built in, while leaving NFSv4 as a module.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux