On Mon, Nov 04, 2013 at 08:05:08PM -0800, Benny Halevy wrote: > On 2013-11-04 14:47, J. Bruce Fields wrote: > > On Tue, Oct 15, 2013 at 09:58:00AM +0300, Benny Halevy wrote: > >> All calls to nfs4_put_delegation are preceded with remove_stid. > > > > Whoops, no, we missed the nfs4_put_delegation call in > > fs/nfsd/nfs4callback.c. > > > > Noticed because some pynfs tests triggered idr warnings about freeing > > the same id twice. > > > > I guess I'll revert. > > OK. Not sure which patch in your submitted series it was, but with the whole series xfstests on NFS 4.1 crashed and burned early on. I'd recommend you run xfstests to test any future changes to the state handling code in nfsd. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html