On Thu, 07 Nov 2013 11:47:55 -0500
Steve Dickson <SteveD@xxxxxxxxxx> wrote:
> Hello,
>
> My thoughts...
>
> On 07/11/13 10:47, Jeff Layton wrote:
> > Because the kernel now looks for krb5 creds by default when mounting, we
> > need to always have clients run rpc.gssd to avoid the 15s hang on the
> > first mount attempt.
> >
> > In situations however where people don't have krb5 set up, this leads to
> > a lot of log spamming on mount attempts. Try to cut down on some of the
> > log chatter by lowering the priority of the log messages in
> > gssd_search_krb5_keytab().
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > ---
> > utils/gssd/krb5_util.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
> > index 697d1d2..2ca3adc 100644
> > --- a/utils/gssd/krb5_util.c
> > +++ b/utils/gssd/krb5_util.c
> > @@ -711,13 +711,13 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt,
> > */
> > if ((code = krb5_kt_get_name(context, kt, kt_name, BUFSIZ))) {
> > k5err = gssd_k5_err_msg(context, code);
> > - printerr(0, "ERROR: %s attempting to get keytab name\n", k5err);
> > + printerr(1, "ERROR: %s attempting to get keytab name\n", k5err);
> > retval = code;
> > goto out;
> > }
> > if ((code = krb5_kt_start_seq_get(context, kt, &cursor))) {
> > k5err = gssd_k5_err_msg(context, code);
> > - printerr(0, "ERROR: %s while beginning keytab scan "
> > + printerr(1, "ERROR: %s while beginning keytab scan "
> > "for keytab '%s'\n", k5err, kt_name);
> > retval = code;
> > goto out;
> I'm thinking these need to stay... I don't think is a good idea
> to mask out messages describing failures...
>
The above message is the one that's the problem when there is no
keytab. I just went ahead and lowered the priority on the others for
good measure. If you don't want to take the above hunk, then there's
probably no need to bother with this patch at all.
> > @@ -727,7 +727,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt,
> > if ((code = krb5_unparse_name(context, kte->principal,
> > &pname))) {
> > k5err = gssd_k5_err_msg(context, code);
> > - printerr(0, "WARNING: Skipping keytab entry because "
> > + printerr(1, "WARNING: Skipping keytab entry because "
> > "we failed to unparse principal name: %s\n",
> > k5err);
> > k5_free_kt_entry(context, kte);
> > @@ -768,7 +768,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt,
> >
> > if ((code = krb5_kt_end_seq_get(context, kt, &cursor))) {
> > k5err = gssd_k5_err_msg(context, code);
> > - printerr(0, "WARNING: %s while ending keytab scan for "
> > + printerr(1, "WARNING: %s while ending keytab scan for "
> > "keytab '%s'\n", k5err, kt_name);
> > }
> I think warnings would be ok to mask out...
>
> steved.
>
> >
> >
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
