On Wed, 2013-10-02 at 09:48 -0400, J. Bruce Fields wrote: +AD4- From: +ACI-J. Bruce Fields+ACI- +ADw-bfields+AEA-redhat.com+AD4- +AD4- +AD4- Failure of this assertion would indeed be serious, but as we've seen a +AD4- BUG() in a worker thread (this can run from rpciod context) can screw up +AD4- the system so badly that the oops doesn't even get to the logs+ADs- better +AD4- to WARN() and soldier on. +AD4- +AD4- Signed-off-by: J. Bruce Fields +ADw-bfields+AEA-redhat.com+AD4- +AD4- --- +AD4- net/sunrpc/auth+AF8-gss/auth+AF8-gss.c +AHw- 2 +-- +AD4- 1 file changed, 1 insertion(+-), 1 deletion(-) +AD4- +AD4- diff --git a/net/sunrpc/auth+AF8-gss/auth+AF8-gss.c b/net/sunrpc/auth+AF8-gss/auth+AF8-gss.c +AD4- index 0846566..254a9f0 100644 +AD4- --- a/net/sunrpc/auth+AF8-gss/auth+AF8-gss.c +AD4- +-+-+- b/net/sunrpc/auth+AF8-gss/auth+AF8-gss.c +AD4- +AEAAQA- -454,7 +-454,7 +AEAAQA- static void gss+AF8-encode+AF8-v1+AF8-msg(struct gss+AF8-upcall+AF8-msg +ACo-gss+AF8-msg, +AD4- gss+AF8-msg-+AD4-msg.len +-+AD0- len+ADs- +AD4- +AD4- gss+AF8-msg-+AD4-msg.data +AD0- gss+AF8-msg-+AD4-databuf+ADs- +AD4- - BUG+AF8-ON(gss+AF8-msg-+AD4-msg.len +AD4- UPCALL+AF8-BUF+AF8-LEN)+ADs- +AD4- +- WARN+AF8-ON+AF8-ONCE(gss+AF8-msg-+AD4-msg.len +AD4- UPCALL+AF8-BUF+AF8-LEN)+ADs- +AD4- +AH0- +AD4- +AD4- static struct gss+AF8-upcall+AF8-msg +ACo- Umm.... Why aren't we using scnprintf() in order to prevent string buffer overflows before they happen? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
