On Tue, 2013-06-25 at 19:05 +0000, Adamson, Andy wrote: > On Jun 25, 2013, at 2:52 PM, "Myklebust, Trond" <Trond.Myklebust@xxxxxxxxxx> > wrote: > > > On Tue, 2013-06-25 at 14:37 -0400, andros@xxxxxxxxxx wrote: > >> From: Andy Adamson <andros@xxxxxxxxxx> > >> > >> nfs4_init_session is called after CREATE_SESSION has set the ca_maxrequestsize > >> and ca_maxresponsesize values obtained from the server. > > > > It had better not be, otherwise the values of > > session->fc_target_max_rqst_sz and session->fc_target_max_resp_sz in > > nfs4_init_channel_attrs() make no sense. > > Well, it does. Shall I move the nfs4_init_session call to before nfs4_init_channel_attrs? > Either that, or change nfs4_init_channel_attrs() to always use NFS_MAX_FILE_IO_SIZE. Right now, the code is just confused (and very confusing). -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
