Re: [PATCH 3/3] NFSv4.1 Fix gdia_maxcount calculation to fit in ca_maxresponsesize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-06-25 at 14:37 -0400, andros@xxxxxxxxxx wrote:
> From: Andy Adamson <andros@xxxxxxxxxx>
> 
> The GETDEVICEINFO gdia_maxcount represents all of the data being returned
> within the GETDEVICEINFO4resok structure and includes the XDR overhead.
> 
> The CREATE_SESSION ca_maxresponsesize is the maximum reply and includes the RPC
> headers (including security flavor credentials and verifiers).

This still looks wrong.

The problem is that pdev->pglen is used both as the total buffer length,
as a function argument and as the reply message length (through the call
to xdr_init_decode_pages). We really should split out those 3 different
roles...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux