On 23/04/13 15:44, J. Bruce Fields wrote:
> On Tue, Apr 23, 2013 at 03:40:43PM -0400, Steve Dickson wrote:
>>
>>
>> On 10/04/13 11:19, J. Bruce Fields wrote:
>>> On Tue, Apr 02, 2013 at 05:45:54PM -0400, Steve Dickson wrote:
>>>> +__be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp,
>>>> + struct nfs4_label *label)
>>>> +{
>>>> + return -EOPNOTSUPP;
>>>
>>> Anything that returns a __be32 is expecting nfserr_something, not
>>> -ERRNO.
>>>
>> I think it makes sense when label are not configured for this to
>> return nfserr_notsupp which will then get turned into a -EOPNOTSUPP,
>> agreed?
>
> Right though as I've said on previous review really this should be
> caught by fs/nfsd/nfs4proc.c:check_attr_support() which is called just
> before nfsd4_set_nfs4_label() in nfsd4_setattr().
It will be once I make nfsd_suppattrs2() only give v4.2 attrs
on 4.2 mounts...
steved.
>
> --b.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
