On Tue, Apr 02, 2013 at 05:45:54PM -0400, Steve Dickson wrote: > +__be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp, > + struct nfs4_label *label) > +{ > + return -EOPNOTSUPP; Anything that returns a __be32 is expecting nfserr_something, not -ERRNO. I made the same comment on a previous review: http://www.spinics.net/lists/linux-nfs/msg36104.html Please keep a careful list of these review comments! --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html