On 25/10/12 09:53, Jeff Layton wrote: >> Is needs_arg really necessary? Once the function is found, just pass >> > it the rest of argv and let the function decide if there should >> > be an argument or not... but again.. just a nit... >> > >> > steved. > No, it's not strictly necessary. The alternative though is to make the > command functions do argv processing, which seemed more ugly to me. I > tend to prefer to keep argv processing in a single place since it can > get sort of hairy to work through the bounds checks after getopt and > such. > > If you feel strongly about it, I can try to change it, but I don't > think the result will be cleaner. > Like I said its a nit... Just a different way to look at it... no issues here keeping it as is... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
