On Sun, Oct 14, 2012 at 12:39 PM, Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
>
> Can't it be called from the rpciod workqueue? I'm not sure what happens
> when we hit a BUG there.
>From personal experience, I can say that killing a workqueue will
cause tons of *very* non-obvious downstream errors, so yeah, if it's
called that way, I could easily see watchdogs firing etc.
> It looks like a bunch of BUG_ON's got added with an xdr rewrite in
> 2b061f9ef216b6d229b06267f188167fd6ab3d9b. Maybe Chuck or someone should
> do a 'git grep BUG fs/lockd' and figure out what those should be
> instead?
Even just replacing them with a WARN_ON_ONCE() would probably help
things. Because BUG_ON() really *really* should be a "last possible
case" thing.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
