On Fri, Oct 12, 2012 at 07:39:22PM -0700, Boaz Harrosh wrote: > On 10/12/2012 07:32 PM, Myklebust, Trond wrote: > > On Fri, 2012-10-12 at 19:27 -0700, Boaz Harrosh wrote: > >> On 10/12/2012 04:52 PM, Linus Torvalds wrote: > >>> Guys, check this report from Larry out. > >>> > >>> Also, why the *HELL* is that a BUG_ON() in the first place? Who was > >>> the less-than-gifted person who decided "if this thing can happen, > >>> let's just kill the whole machine"? > >>> > >> > >> Something is trivially weird > >> > >> fs/lockd/clntxdr.c:226 is in this static function: > >> encode_nlm_stat() > >> > >> encode_nlm_stat() is called in two places > >> static void nlm_xdr_enc_res(...) > >> and > >> static void nlm_xdr_enc_testres(...) > >> > >> But these two are not called anywhere. In-fact a Kernel wide grep > >> returns a single occurrence of both > > > > They are used in the nlm_procedures[] array as TEST_RES, LOCK_RES, > > CANCEL_RES, UNLOCK_RES and GRANTED_RES xdr encoding procedures. > > Ha, sorry that was impossible to find. OK I'll have a look Everybody falls into that trap at least once. Any objections to killing those macros and expanding that stuff out? --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
