On Oct 13, 2012, at 1:18 PM, Wolfram Gloger <wmglo@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
>>> - /*
>>> - * Update option string to be recorded in /etc/mtab.
>>> - */
>>> - if (po_join(options, mi->extra_opts) == PO_FAILED) {
>>> + if (po_join(options, &extra_opts) == PO_FAILED) {
>>
>> This doesn't look right to me, but I haven't had time to test it. Doesn't this hunk cause the mount system call to ignore what's in mi->extra_opts?
> ...
>>> result = nfs_sys_mount(mi, options);
>
> No, nfs_sys_mount() does not use mi->extra_opts at all, only the
> binary options.
This is the text-based code, which I wrote. nfs_sys_mount() passes an options string (NUL-terminated C string) to the kernel, not a binary object. That string contains all the FS-specific mount options specified by the user.
But your patch makes that string empty, by my reading. I think this is incorrect.
> It would perhaps be clearer to handle the update of mi->extra_opts in
> nfs_sys_mount(), but only after a successful mount(2) call.
> A more invasive patch.
>
> Regards,
> Wolfram.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
