Hi,
> > - /*
> > - * Update option string to be recorded in /etc/mtab.
> > - */
> > - if (po_join(options, mi->extra_opts) == PO_FAILED) {
> > + if (po_join(options, &extra_opts) == PO_FAILED) {
>
> This doesn't look right to me, but I haven't had time to test it. Doesn't this hunk cause the mount system call to ignore what's in mi->extra_opts?
...
> > result = nfs_sys_mount(mi, options);
No, nfs_sys_mount() does not use mi->extra_opts at all, only the
binary options.
It would perhaps be clearer to handle the update of mi->extra_opts in
nfs_sys_mount(), but only after a successful mount(2) call.
A more invasive patch.
Regards,
Wolfram.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
