Peng, Tao wrote: > -----Original Message----- > From: linux-nfs-owner@xxxxxxxxxxxxxxx [mailto:linux-nfs-owner@xxxxxxxxxxxxxxx] On Behalf Of Wei > Yongjun > Sent: Tuesday, September 25, 2012 1:44 PM > To: Trond.Myklebust@xxxxxxxxxx > Cc: yongjun_wei@xxxxxxxxxxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx > Subject: [PATCH] NFS: fix the return value of nfs4_blkdev_get() > > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > In case of error, the function nfs4_blkdev_get() return NULL pointer. > But the user nfs4_blk_decode_device() check the return value by using > IS_ERR() and get error code from the return value. So we should better > change the return value of nfs4_blkdev_get() to return ERR_PTR(). > Yeah, it is merely mess and should be just removed... It's leftover debug code. Get rid of it. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
