-----Original Message----- From: Peng, Tao [mailto:tao.peng@xxxxxxx] Sent: 2012年9月25日 15:12 To: Wei Yongjun; Trond.Myklebust@xxxxxxxxxx Cc: Yongjun Wei (RD-CN); linux-nfs@xxxxxxxxxxxxxxx Subject: RE: [PATCH] NFS: fix the return value of nfs4_blkdev_get() > -----Original Message----- > From: linux-nfs-owner@xxxxxxxxxxxxxxx > [mailto:linux-nfs-owner@xxxxxxxxxxxxxxx] On Behalf Of Wei Yongjun > Sent: Tuesday, September 25, 2012 1:44 PM > To: Trond.Myklebust@xxxxxxxxxx > Cc: yongjun_wei@xxxxxxxxxxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx > Subject: [PATCH] NFS: fix the return value of nfs4_blkdev_get() > > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > In case of error, the function nfs4_blkdev_get() return NULL pointer. > But the user nfs4_blk_decode_device() check the return value by using > IS_ERR() and get error code from the return value. So we should better > change the return value of nfs4_blkdev_get() to return ERR_PTR(). > Yeah, it is merely mess and should be just removed... How about following patch? It is OK to me. Regards, Yongjun Wei TREND MICRO EMAIL NOTICE The information contained in this email and any attachments is confidential and may be subject to copyright or other intellectual property protection. If you are not the intended recipient, you are not authorized to use or disclose this information, and we request that you notify us by reply mail or telephone and delete the original message from your mail system.��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
