On Thu, 2012-08-09 at 10:36 +0800, Peng Tao wrote: > On Thu, Aug 9, 2012 at 3:03 AM, Myklebust, Trond > <Trond.Myklebust@xxxxxxxxxx> wrote: > > On Wed, 2012-08-08 at 09:49 +0800, Peng Tao wrote: > >> pnfs_within_mdsthreshold() is called inside pg_init. We need > >> to set read_io/write_io before that. > > > > Why? > If we don't set read_io/write_io before calling pg_init, we fail > pnfs_within_mdsthreshold() and IO goes to MDS. > A simple test case: > dd if=foo of=/mnt/pnfs/bar bs=10M count=1 oflag=direct > My point was that this explanation needs to go into the changelog of the commit. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥