On 06/01/2012 10:41 AM, Myklebust, Trond wrote:
On Fri, 2012-06-01 at 10:26 -0600, Orion Poplawski wrote:So absence of @ indicates no need to translate locally, so don't complain about it. So how about this: --- ./libnfsidmap-0.25/nss.c.nobody 2011-12-05 13:28:10.000000000 -0700 +++ ./libnfsidmap-0.25/nss.c 2012-06-01 10:23:53.408603517 -0600 @@ -177,9 +177,10 @@ IDMAP_LOG(4, ("nss_getpwnam: name '%s' domain '%s': " "resulting localname '%s'\n", name, domain, localname)); if (localname == NULL) { - IDMAP_LOG(0, ("nss_getpwnam: name '%s' does not map " - "into domain '%s'\n", name, - domain ? domain : "<not-provided>")); + if (strchr(name, '@' != NULL) + IDMAP_LOG(0, ("nss_getpwnam: name '%s' does not map " + "into domain '%s'\n", name, + domain ? domain : "<not-provided>")); goto err_free_buf; }ACK. That looks about right...
Another possibility is that we shouldn't even be calling nss_getpwnam() in the first place in this case, but I don't know the code well enough to pursue that or if it's worth it.
-- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder Office FAX: 303-415-9702 3380 Mitchell Lane orion@xxxxxxxx Boulder, CO 80301 http://www.nwra.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
