On 2012-05-29 10:13, Boaz Harrosh wrote: > On 05/28/2012 09:29 PM, Benny Halevy wrote: > >> On 2012-05-28 21:09, Boaz Harrosh wrote: > > >>> BTW after I finish implementing my stuff. I think it would be easy >>> to implement that open_state_id thing. All we need is to save the >>> open_state_id somewhere per-file or somehow identify it's receive, >>> And then just call nfs4_roc() which will do the proper work. >> >> It's any non layout stateid so it should be pretty easy (in theory :). >> See nfs4_process_layout_stateid() >> if (stid->sc_type != NFS4_LAYOUT_STID) {} >> >> We should be able to locate the layout stateid, if any, on the >> fp->fi_layout_states list by matching stid->sc_client. >> > > > Does look easy, then. I thought it should be. I will have a shot > at it and add it to my patchset. Thanks! > > Do you know if we have a test case for this in pyNFS? No, not that I know of. > > I need to think if we can cause this with the Linux client? > Perhaps: not set ROC, access a file and close, clear caches > at both ends, re access, something like that, I'll try. Cool. Thanks a bunch for picking this up! Benny > > Thanks > Boaz > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html