Re: [PATCH 1/3] NFS41: add pnfs_dio_begin/dio_end

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-05-29 at 01:36 +0800, Peng Tao wrote:
> On Tue, May 29, 2012 at 1:24 AM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> > On 05/28/2012 08:14 PM, Peng Tao wrote:
> > Don't add new parameters to the functions. Add new fields to the passed
> > structures.
> >
> Got it.

The other thing is that since struct nfs_pageio_descriptor is allocated
on the stack, let's please not grow it too much further. If you need to
add structures that are private to your layout driver, then please
allocate those structures dynamically, and use a void *pg_layout_private
to point to them.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux