> -----Original Message----- > From: Myklebust, Trond [mailto:Trond.Myklebust@xxxxxxxxxx] > Sent: Monday, May 28, 2012 11:43 AM > To: Peng, Tao > Cc: bergwolf@xxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx > Subject: RE: [PATCH 1/3] NFS41: add pnfs_dio_begin/dio_end > > On Sun, 2012-05-27 at 22:30 -0400, tao.peng@xxxxxxx wrote: > > I'm afraid there is. There is no way to pass struct blk_plug around pg_init/pg_doio, unless we put > it in struct nfs_pageio_descriptor, which I think is more intrusive and less efficient as it is only > useful for block layout driver in DIO case. > > Then add a 'void *pg_layout_private' field to nfs_pageio_descriptor and > allocate the struct blk_plug dynamically. > OK. I thought data structure change is more intrusive because it affects all layout drivers and generic NFS as well. But since you think it is OK, I will change it as you suggested. Thanks, Tao ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥