> -----Original Message----- > From: Myklebust, Trond [mailto:Trond.Myklebust@xxxxxxxxxx] > Sent: Monday, May 28, 2012 11:45 AM > To: Peng, Tao > Cc: bergwolf@xxxxxxxxx; linux-nfs@xxxxxxxxxxxxxxx > Subject: RE: [PATCH 3/3] pnfsblock: bail out unaligned DIO > > On Sun, 2012-05-27 at 22:30 -0400, tao.peng@xxxxxxx wrote: > > As explain in the other mail, it is necessary to have pnfs_dio_begin/end, so I prefer to do the test > as early as possible, which is in pnfs_dio_begin. > > There is no pnfs_dio_begin/end. OK. I will put DIO alignment tests inside pg_init. And any comments on for stable patch in the thread ([PATCH] pnfsblock: bail out page unaligned IO)? If you agree, I will base DIO changes on top of it to avoid conflicts. There are reasons to test alignment at different place for buffer IO and DIO. For buffer IO, pg_init isn't the right place because we don't have nfs page there. For DIO, pg_test isn't the right place because we need to check cross page boundary. Thanks, Tao ��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
