On Sat, 28 Apr 2012 07:26:39 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Mon, Apr 23, 2012 at 11:04:19AM +1000, NeilBrown wrote: > > On Fri, 20 Apr 2012 18:46:15 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxx> > > wrote: > > > > > mountd: unconditionally resolve ip address > > > > Not a good idea. If /etc/exports only contains IP address and subnets, then > > we don't ever want to do any address resolution. The "resolve ip address" > > must at least be conditional on "are there any domain-name, wild-cards, > > netgroups in /etc/exports". > > The bug is my changelog. All we're really doing there is parsing the ip > address, not resolving anything. Ahhh. I see that now. Thanks. > > ... > > > mountd: ignore use_ipaddr and just try both client types > > > > Maybe ... though if we could syntactically distinguish "use_ipaddr" domains > > from "!use_ipaddr" domain and still just choose one test to perform, I think > > I'd prefer that. > > Hm, OK. Something like the following? (Totally untested.) Yes, that looks good. I could probably bike-shed for a while about the leading '?', and wonder if '!' or '$' might be better choices, or if leading '[' and trailing ']' is best but I won't. He who writes the code makes the choice. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
