Re: [PATCH 0/3] Fix use_ipaddr race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2012 at 11:04:19AM +1000, NeilBrown wrote:
> On Fri, 20 Apr 2012 18:46:15 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxx>
> wrote:
> 
> >   mountd: unconditionally resolve ip address
> 
> Not a good idea.  If /etc/exports only contains IP address and subnets, then
> we don't ever want to do any address resolution.  The "resolve ip address"
> must at least be conditional on "are there any domain-name, wild-cards,
> netgroups in /etc/exports".

The bug is my changelog.  All we're really doing there is parsing the ip
address, not resolving anything.

...
> >   mountd: ignore use_ipaddr and just try both client types
> 
> Maybe ... though if we could syntactically distinguish "use_ipaddr" domains
> from "!use_ipaddr" domain and still just choose one test to perform, I think
> I'd prefer that.

Hm, OK.  Something like the following?  (Totally untested.)

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux