On Wed, Apr 18, 2012 at 10:51:47AM -0400, Jeff Layton wrote: > On Wed, 18 Apr 2012 14:41:45 +0000 > "Myklebust, Trond" <Trond.Myklebust@xxxxxxxxxx> wrote: > > > Right. Random (and wrong!) changes such as the above won't fix the > > problem. That code is perfectly correct (look at the nfs4_reclaim_locks > > error cases to see why). > > > > Ugh, ok I see and that code is correct even if it's a bit hard to > follow... > > We clear the state_flag_bit on the first attempt against that lock so > if it returns 0 (meaning a successful reclaim, we'll skip over it on > the next pass through the loop. > > > Have you instead looked into what these applications are doing? Are they > > perhaps opening the file read only, then trying to apply an exclusive > > BSD lock (something which NFSv4 cannot support)? > > > > IOW: does the problem go away if you mount with 'local_lock=flock'? > > > I suspect that that is the trigger here. Sadly common among userspace > apps... Ok, I'll ask some of the guys reporting the bug to try to use that option to mount. Is there any other useful information that could be collected to help sorting this out? Btw, there was someone reporting that an easy reproducer of this problem is to just run: $ /usr/bin/flock /file/on/nfs echo Fish Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
