On Wed, 18 Apr 2012 12:26:10 +0100 Luis Henriques <luis.henriques@xxxxxxxxxxxxx> wrote: > Hi, > > We have a bug reporting a regression in mainline kernel. Basically, the > bug reporters are seeing lots of messages: > > [ 48.701213] NFS: nfs4_reclaim_open_state: Lock reclaim failed! > [ 48.701990] NFS: nfs4_reclaim_open_state: Lock reclaim failed! > [ 53.696076] nfs4_reclaim_open_state: 6440 callbacks suppressed > > This happens when mounting a user's home directory over NFS. > > Is this a known issue being addressed at the moment? Is there any > information needed to help debugging the issue? > > The original bug report can be found here: > > http://bugs.launchpad.net/bugs/974664 > > And there's also a similar report for Fedora: > > https://bugzilla.redhat.com/show_bug.cgi?id=811138 > > Cheers, This code in nfs4_reclaim_open_state() looks wrong to me, but I'm not that familiar with this code so I could be wrong: -------------------[snip]-------------------- status = ops->recover_open(sp, state); if (status >= 0) { status = nfs4_reclaim_locks(state, ops); if (status >= 0) { spin_lock(&state->state_lock); list_for_each_entry(lock, &state->lock_states, ls_locks) { if (!(lock->ls_flags & NFS_LOCK_INITIALIZED)) pr_warn_ratelimited("NFS: " "%s: Lock reclaim " "failed!\n", __func__); } spin_unlock(&state->state_lock); nfs4_put_open_state(state); goto restart; } } -------------------[snip]-------------------- Shouldn't the status check after nfs4_reclaim_locks be reversed? -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
