Jeff Layton <jlayton@xxxxxxxxxx> writes:
>>
>> Won't something like fstatat(AT_FDCWD, "", &stat, AT_EMPTY_PATH) risk
>> looping forever there, or am I missing something?
>>
>
> To make sure I understand, that should be "shortcut" for a lookup of the
> cwd?
>
> So I guess the concern is that you'd do the above and get a successful
> lookup since you're just going to get back the cwd. At that point,
> you'd attempt the getattr and get ESTALE back. Then, you'd redo the
> lookup with LOOKUP_REVAL set -- but since we're operating on the
> cwd, we don't have a way to redo the lookup since we don't have a
> pathname that we can look up again...
>
> So yeah, I guess if you're sitting in a stale directory, something like
> that could loop eternally.
>
> Do you think the proposed check for fatal_signal_pending is enough to
> mitigate such a problem? Or do we need to limit the number of retries
> to address those sorts of loops?
Lets step back a bit.
The retry is needed when when we discover during ->getattr() that the
cached lookup returned a stale file handle.
If the lookup wasn't cached or if there was no lookup at all
(stat(".") and friends) then retrying will not gain anything.
And that also means that retrying multiple times is pointless, since
after the first retry we are sure to have up-to-date attributes.
Unfortunately it's impossible for the filesystem to know whether a
->getattr (or other inode operation) was perfromed after a cached or a
non-cached lookup.
I'm not sure what the right interface for this would be. One would be
to just pass the "cached-or-not" information as a flag. That works for
getattr() but not for other operations.
Another is to introduce atomic lookup+foo variants of these operations
just like for open. E.g. the lookup+getattr is called if the cached
lookup fails or if the cached lookup succeeds and the plain ->getattr
call returns ESTALE.
Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
